Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KXI-46633] Add confirm dialog to connect #317

Merged
merged 12 commits into from
May 23, 2024
Merged

[KXI-46633] Add confirm dialog to connect #317

merged 12 commits into from
May 23, 2024

Conversation

Philip-Carneiro-KX
Copy link
Collaborator

Changes introduced by this PR

  • Add confirm dialog offering to connect to a not connected connection
  • add the dialog to workbooks
  • add the dialog for actions in DS

@Philip-Carneiro-KX Philip-Carneiro-KX requested a review from ecmel May 23, 2024 10:21
@Philip-Carneiro-KX Philip-Carneiro-KX self-assigned this May 23, 2024
@Philip-Carneiro-KX Philip-Carneiro-KX changed the base branch from main to dev May 23, 2024 10:21
@kx-sonarqube
Copy link

kx-sonarqube bot commented May 23, 2024

Quality Gate passed Quality Gate passed

The SonarQube Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
94.4% 94.4% Coverage on New Code
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@Philip-Carneiro-KX Philip-Carneiro-KX merged commit 0e8f0ab into dev May 23, 2024
5 checks passed
@Philip-Carneiro-KX Philip-Carneiro-KX deleted the KXI-46633 branch May 23, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecmel ecmel ecmel approved these changes

Assignees

@Philip-Carneiro-KX Philip-Carneiro-KX

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Philip-Carneiro-KX @ecmel